Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset enables compatibility with PHP 8.4+ while retaining compatibility as far back as PHP 7.3.
The primary concern is the
nesbot/carbonversion dependency, which needs to be v3.x for PHP 8.4+.To achieve this, the unused
PHPStandependencies and config were removed, and thePHP_CSdependencies and config updated, with minor fixups to formatting in some code.We can add
PHPStanback into the mix in the future.Testing:
make clean-all && make testmake clean-all && make testCheck that PHP 7.x uses
nesbot/carbon2.x while PHP 8.x usesnesbot/carbon3.x.Use this branch in a real project to test that it works without error and enables usage of Carbon v3 when using PHP 8.1+ (I'll raise a follow-on PR on another project for this).